Repository navigation
fix(composer): keep model rows on one line and truncate long names - #1717
Merged
Merged
Conversation
The model menu wrapped a long model name onto a second line, so a row's height varied with its name and the list read unevenly. The name now takes whatever width the row has left after its trailing markers and truncates with an ellipsis beyond that. The provider trailing each recent row also yields width before the model name, so a long name is not the only part that has to survive on the shared line. The full name and the wire id stay available as the row's title.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
输入框的模型列表里,模型名过长时会换行,行高随名字长度变化,整列读起来参差;最近使用那几行的提供商名(WTQ Pool (CN) / Team / Wang)挤在右侧把名字压成两行。
改动
flex-wrap: nowrap),名字超出可用宽度时以省略号截断。title上,悬停即可看到。验证
pnpm --filter @pi-desktop/desktop typecheck通过node --test test/*.test.mjs(apps/desktop)4020 通过 / 0 失败